Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a 'slot nickname' field for easily ID'ing chara slots #436

Merged
merged 5 commits into from
Sep 10, 2024

Conversation

BonniePandora
Copy link
Contributor

About the pull request

Adds a new field on the character setup screen with which to give the save slot a 'nickname' for easier identification at a glance, so you can tell what characters are for USCM, UPP, TWE, etc etc.

Explain why it's good for the game

No more getting mildly confused about which chara is meant for which faction if you have a gagglefuck of them made up.

Testing Photographs and Procedure

Tested extensively on a local instance, works without issue and as intended.

Screenshots & Videos

image
The final version of the code removed the (brackets) from either side of the slot nickname result on the setup page, but retains it on the load-slot window.

Changelog

🆑
qol: Adds a new 'nickname' for character slots
ui: adjusted the character setup menu to have a field for the above
/:cl:

Copy link
Contributor

@Doubleumc Doubleumc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To avoid confusion, instead of calling it "nickname"/nickname call it something like "slot label"/slot_label.

Other than that, code good.

@BonniePandora
Copy link
Contributor Author

To avoid confusion, instead of calling it "nickname"/nickname call it something like "slot label"/slot_label.

Other than that, code good.

Changed from nickname in all the visible stuff!

@Doubleumc Doubleumc merged commit 99303e1 into cmss13-devs:master Sep 10, 2024
35 checks passed
cm13-github added a commit that referenced this pull request Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants